Add helmValuesFrom configuration for importing Helm values#128
Merged
stefanprodan merged 1 commit intostefanprodan:mainfrom Feb 12, 2026
Merged
Add helmValuesFrom configuration for importing Helm values#128stefanprodan merged 1 commit intostefanprodan:mainfrom
stefanprodan merged 1 commit intostefanprodan:mainfrom
Conversation
westelh
changed the title
|
|
||
| helmValues?: {...} | ||
|
|
||
| valuesFrom?: [...{ |
Owner
There was a problem hiding this comment.
can you please rename this to helmValuesFrom to match the module conventions.
Contributor
Author
There was a problem hiding this comment.
Thank you for reviewing. I updated PR to match the naming conventions.
Owner
|
Please squash and rename the PR. |
westelh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
helmValuesFromsupport to flux-helm-releaseSummary
This adds first-class support for
helmValuesFromin theflux-helm-releasemodule so users can source Helm values from ConfigMaps or Secrets. The config schema and HelmRelease rendering now exposespec.helmValuesFrom, and the module README documents the new option.Changes
helmValuesFromto the module configuration schema with Flux-compatible fields.spec.valuesFromin the generated HelmRelease when configured.helmValuesFromin debug values.helmValuesFromin the module README.Testing
cue fmt ./...timoni mod vet --debugtimoni apply test . --values debug_values.cue --dry-runAll passed.