Suppress the display of informative messages when wanting to display the result of --print-info <info flags>#1053
Merged
stefanberger merged 3 commits intomasterfrom Aug 18, 2025
Conversation
stefanberger
force-pushed
the
stefanberger/suppress_logging_getinfo
branch
2 times, most recently
from
0fcac75 to
6c27a95
Compare
When the special logging file descriptor SUPPRESS_INFO_LOGGING is chosen, then only suppress informative and warning messages while still allowing error messages to be printed to stderr. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Have warnings print to stdout since they do not lead to swtpm exiting with an error code. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
stefanberger
force-pushed
the
stefanberger/suppress_logging_getinfo
branch
2 times, most recently
from
8861487 to
93b0919
Compare
When printing the output of the info flags, the resuling JSON printed to stdout should be the only printout. Therefore, suppress all informative output to stdout so that either the JSON is the only output or only error messages are printed. Fixes: 3f551e1 ("swtpm: Implement --print-info to run TPMLIB_GetInfo with flags") Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
stefanberger
force-pushed
the
stefanberger/suppress_logging_getinfo
branch
from
93b0919 to
7158def
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid displaying informative message when displaying the JSON result of a --print-info request to avoid mixing the JSON with regular text messages.