Skip to content

fix(packages/cli): package manager bun error #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GitTuanKiet wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(packages/cli): package manager bun error #222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli/src/commands/add.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ export const add = new Command()
"add",
packageManager === "deno" ? "--npm" : "",
...item.dependencies,
], { cwd });
].filter(Boolean), { cwd });
Copy link
Copy Markdown

@RATIU5 RATIU5 Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, though a conditional spread (...(packageManager === "deno" ? ["--npm"] : [])) is safer since it only targets the intended argument rather than silently filtering out any falsy values in item.dependencies too.

}
}

Expand Down