Fix TypeScript errors in helmetData tests; run CI on push to all branches#265
Merged
Fix TypeScript errors in helmetData tests; run CI on push to all branches#265
Conversation
Co-authored-by: staylor <52932+staylor@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update for React 19 support and TypeScript cleanup
Fix TypeScript errors in helmetData tests; run CI on all branches
Mar 3, 2026
staylor
reviewed
Mar 3, 2026
.github/workflows/ci.yml
Outdated
Co-authored-by: staylor <52932+staylor@users.noreply.github.com>
Copilot
AI
changed the title
Fix TypeScript errors in helmetData tests; run CI on all branches
Fix TypeScript errors in helmetData tests; run CI on push to all branches
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making
HelmetDataContext.helmetnullable (from a prior fix) caused TypeScript TS18047 "possibly null" errors in the server-side helmetData tests, and CI was only configured to run on pushes/PRs targetingmain.Changes
__tests__/server/helmetData.test.tsx— Add non-null assertions (!) to the threehelmetData.context.helmetaccesses in server tests. The value is always populated after rendering in these test cases; the assertion satisfies TypeScript without altering runtime behavior..github/workflows/ci.yml— Removebranches: [main]restriction and thepull_requesttrigger so CI runs on every push to any branch (avoids duplicate runs on PRs).🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.