Skip to content

fix: remove DOM side effects from React19Dispatcher render()#264

Closed
Copilot wants to merge 5 commits intov3.0.0from
copilot/sub-pr-260-yet-again
Closed

fix: remove DOM side effects from React19Dispatcher render()#264
Copilot wants to merge 5 commits intov3.0.0from
copilot/sub-pr-260-yet-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 3, 2026

  • Move applyNonHostedAttributes() to componentDidMount (keep in componentDidUpdate)
  • Remove init() method and its call from render()
  • Run tests to validate (298 passed)
  • Remove accidentally committed package-lock.json
  • Resolve merge conflicts by syncing with updated v3.0.0 base branch (303 tests pass)
  • Sync CI config and helmetData tests with latest v3.0.0 base branch

The original render side-effect fix is already incorporated in the base branch. This PR now has zero diff against v3.0.0 and can be closed as resolved.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits March 3, 2026 11:43
…effects from render

Co-authored-by: staylor <52932+staylor@users.noreply.github.com>
Co-authored-by: staylor <52932+staylor@users.noreply.github.com>
Copilot AI changed the title [WIP] Update for React 19 support and TypeScript cleanup fix: remove DOM side effects from React19Dispatcher render() Mar 3, 2026
@staylor
Copy link
Copy Markdown
Owner

staylor commented Mar 3, 2026

@copilot you have merge conflicts

Co-authored-by: staylor <52932+staylor@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 3, 2026

@copilot you have merge conflicts

Resolved in 1e477fb. I synced all conflicting files (src/React19Dispatcher.tsx, src/HelmetData.ts, src/Provider.tsx, src/server.ts, and the updated test files) with the current v3.0.0 base branch. All 303 tests pass.

@staylor staylor marked this pull request as ready for review March 3, 2026 11:57
@staylor
Copy link
Copy Markdown
Owner

staylor commented Mar 3, 2026

@copilot mege conflicts still? rebase this PR and see if still relevant

Co-authored-by: staylor <52932+staylor@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 3, 2026

@copilot mege conflicts still? rebase this PR and see if still relevant

Synced in 9f7c45e. I can't rebase (no force push available), but I've updated the 2 remaining files (.github/workflows/ci.yml and __tests__/server/helmetData.test.tsx) to match the latest v3.0.0. The PR now has zero diff against the base branch — the original render side-effect fix is already fully incorporated in v3.0.0. This PR can be closed as resolved.

@staylor staylor closed this Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants