Fix priority.toComponent() returning undefined when prioritizeSeoTags is false#262
Merged
Fix priority.toComponent() returning undefined when prioritizeSeoTags is false#262
priority.toComponent() returning undefined when prioritizeSeoTags is false#262Conversation
…oTags is false Co-authored-by: staylor <52932+staylor@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on React 19 support and TypeScript cleanup
Fix Mar 3, 2026
priority.toComponent() returning undefined when prioritizeSeoTags is false
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default
priorityMethodsinmapStateOnServerhadtoComponent: () => {}— an empty function body that implicitly returnsundefined, violating theHelmetDatuminterface contract oftoComponent(): React.ReactElement[].Changes
src/server.ts: Change the defaulttoComponentfallback to explicitly return an empty array, matching theHelmetDatumtype:This ensures
helmet.priority.toComponent()is always safe to call (e.g. spread into JSX) regardless of whetherprioritizeSeoTagsis enabled.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.