This repository was archived by the owner on Apr 26, 2019. It is now read-only.
MetaMask: Use web3.currentProvider instead of window.web3 #242#455
Open
debragail wants to merge 2 commits intostatus-im:developfrom
Open
MetaMask: Use web3.currentProvider instead of window.web3 #242#455debragail wants to merge 2 commits intostatus-im:developfrom
debragail wants to merge 2 commits intostatus-im:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #242
-Updated common.clj to web 3
upgrading cljs-web3 to 0.19.0-0-11 and replacing the web3 constructor we defined here:
open-bounty/src/cljs/commiteth/common.cljs
Lines 10 to 11 in b76ad70
(defn web3 []
(gobj/get js/window "web3"))
with the one that has been added to cljs-web3 in this PR: district0x/cljs-web3#8