Open
Conversation
BREAKING CHANGE: rename prefix and suffix to prefixText and suffixText
daenub
force-pushed
the
287-input-suche-button
branch
from
6e20fee to
7907dec
Compare
daenub
requested changes
Jun 26, 2025
| * @fires {CustomEvent} input - Dispatched when the value of the input element changes. | ||
| * @fires {CustomEvent} change - Dispatched when the value of the input element changes and the input element loses focus. | ||
| * | ||
| * @tagname leu-input |
Member
There was a problem hiding this comment.
Das ist noch der falsche Element Name
| } as const | ||
|
|
||
| /** | ||
| * A text input element. |
Member
There was a problem hiding this comment.
Copy Paste überbleibsel vom Input Element
| submitLabel?: string | ||
|
|
||
| @state() | ||
| private _identifier: string = "" |
Member
There was a problem hiding this comment.
Wie schon bilateral besprochen. Den _identifier brauchts nicht mehr. id ist auf den Scope vom Shadow DOM beschränkt.
| * If the id attribute is set, the value of the id attribute is returned. | ||
| * Otherwise a random id is generated and returned. | ||
| */ | ||
| private getId() { |
Member
There was a problem hiding this comment.
Obsolet. Wie schon oben erwähnt.
|
|
||
| import styles from "./search.css" | ||
|
|
||
| export const SEARCH_SIZES = { |
Member
There was a problem hiding this comment.
Die definierten Konstante würde ich in die Story verschieben, da sie nur dort verwendet wird. Bin das jetzt auch bei den anderen Components am nachziehen
Member
|
Mir sind visuell noch ein zwei Dinge aufgefallen:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sali Dan,
Kannst Du darüber schauen:
LG