Moves Preview Server to Use Kestrel#449
Merged
daveaglick merged 4 commits intostatiqdev:developfrom Feb 15, 2017
Merged
Conversation
876080d to
49e8223
Compare
Silvenga
commented
Feb 14, 2017
| <None Include="App.config" /> | ||
| <None Include="packages.config" /> | ||
| </ItemGroup> | ||
| <ItemGroup> |
Contributor
Author
There was a problem hiding this comment.
This is the hacky include. This assumes a x86 compatible build.
Member
Contributor
Author
Member
|
That sounds like a plan - no reason to make you deal with the split while trying to work out the rebase. We'll merge this one as-is, take another look at LiveReload, hopefully be able to merge that one now, and then I'll split them out. That'll be a better verification anyway since we'll know it worked pre-split. Hopefully I'll get a chance to merge this one later tonight or early tomorrow. |
Member
|
Worked fine on my test merge, so I'll pull this in and we'll deal with any other problems as they arise. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the Kestrel server.
The move was easier than expected, most of the changes are the new packages, the preview server is virtually the same.
A basic pro/cons list (some are IMHO):
Gains
urlacl😒).Losses
Considerations