Skip to content

Mavenize the project#41

Closed
dakusui wants to merge 1 commit intostathissideris:masterfrom
dakusui:mavenized
Closed

Mavenize the project#41
dakusui wants to merge 1 commit intostathissideris:masterfrom
dakusui:mavenized

Conversation

@dakusui
Copy link
Copy Markdown

@dakusui dakusui commented Oct 27, 2018

This pull request offers a fix for Issue #40 , "Mavenization".
Actually, I'm not sure if this is a branch for pull requesting.
Please let me know the way you prefer to be pull requested.

@dakusui dakusui mentioned this pull request Oct 27, 2018
<url>https://github.com/dakusui/ditaa</url>
<connection>scm:git:git://github.com/dakusui/ditaa.git</connection>
<developerConnection>scm:git:ssh://git@github.com/dakusui/ditaa.git</developerConnection>
<tag>95a481e5a01d07317edc4af4cbdfb4c821090437</tag>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this tag value came from some example where maven project was release.

Should not be here, as fare as I know

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing out.
I'm closing this pull request since this is not necessary anymore.

@dakusui
Copy link
Copy Markdown
Author

dakusui commented Aug 24, 2019

Since the pull request that depends on this was reworked in #54 and this became unnecessary.
I'm closing this.

@dakusui dakusui closed this Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants