Skip to content

getParent should not return null for targetFilename #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ovruni wants to merge 1 commit into
base: master
Choose a base branch
from
Open

getParent should not return null for targetFilename #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/org/stathissideris/ascii2image/core/HTMLConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ public boolean convertHTMLFile(

System.out.println("Generating diagrams... ");

File imageDir = new File(new File(targetFilename).getParent() + File.separator + imageDirName);
File imageDir = new File(new File(targetFilename).getAbsoluteFile().getParent() + File.separator + imageDirName);
if(!imageDir.exists()){
if(!imageDir.mkdir()){
System.err.println("Could not create directory " + imageDirName);
Expand All @@ -171,7 +171,7 @@ public boolean convertHTMLFile(

for(String URL : diagramList.keySet()) {
String text = (String) diagramList.get(URL);
String imageFilename = new File(targetFilename).getParent() + File.separator + URL;
String imageFilename = new File(targetFilename).getAbsoluteFile().getParent() + File.separator + URL;
if(new File(imageFilename).exists() && !options.processingOptions.overwriteFiles()){
System.out.println("Error: Cannot overwrite file "+URL+", file already exists." + " Use the --overwrite option if you would like to allow file overwrite.");
continue;
Expand Down