proptest and proptesti confidence interval update, based on issue #166
#167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ernative, as proposed in issue 166
adw96
approved these changes
May 20, 2025
Contributor
adw96
left a comment
adw96
left a comment
There was a problem hiding this comment.
thank you so much, @svteichman ! it looks wonderful. thanks for being so thorough
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in issue #166,
proptestandproptesticonfidence intervals are switched to all be two sided, regardless of the alternative being tested. In this PR, the version is incremented, this is updated inproptest()andproptesti(), and tests are updated to reflect this change.@adw96 do you mind giving this a quick review to confirm that it matches what you had in mind?