-
Notifications
You must be signed in to change notification settings - Fork 4
Perform test of identical sample sizes in anova.uRegress() to address issue #158 #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The data appear to have been moved from the old address of http://www.emersonstatistics.com/datasets/mri.txt to the new address of https://rct-design.com/TeachingMaterials/Datasets/mri.txt
|
@svteichman Hi Sarah! I just made a small change to anova.uRegress(), which checks that the same number of samples are used in the full and reduced model, as described in issue #158. This is particularly an issue when the full model contains missing data in one of the variables that is not included in the reduced model. Due to unrelated check errors, I also had to make some edits to the documentation, old tests, and R-CMD-check.yml workflow files. I am particularly unfamiliar with the .yml file, although ChatGPT was particularly helpful in debugging this error. Please let me know if my changes look good to merge—I would also be happy to run this by Amy if you prefer! |
|
Thanks @gthopkins! I'll take a look at this tomorrow, especially at the .yaml files (I've recently had to update these for corncob and radEmu, so I imagine some of the same issues were coming up with these ones, related to versions of things being out of date. This is a good reminder for me to check this out for our other lab packages and update those as well!) |
svteichman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks great @gthopkins. One quick question, why did you make print.augCoefficients and fitted.uRegress exported functions here? I was just wondering, as I couldn't tell if it directly addresses the PR or if it was needed to deal with errors/warnings/notes in the R-CMD-check
|
Thank you, @svteichman! As you suggested, I exported |
|
No worries, I think that's totally fine (in my opinion, not a lot of downsides to exporting additional functions if it helps you in some way), I just wanted to check in. I'll merge! |
This pull request addresses issue #158 by checking that the sample sizes of the full and reduced models included in
rigr::anova.uRegress()are fit on identical sample sizes (as a surrogate check that the models are fitted on identical data among shared variables). This was a problem when a variable included in the full model contained missing data, for which the default action inrigr::regress()is to subset to complete cases, however this makes the anova test invalid without further consideration.