Skip to content

If inventory not tracked assume we can sell it #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanmitchell merged 3 commits into from
Mar 17, 2026
Merged

If inventory not tracked assume we can sell it #341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7402e5
If inventory not tracked assume we can sell it
ryanmitchell Mar 17, 2026
1a3ebec
Merge branch 'main' into fix/inventory-tracked-policy
ryanmitchell Mar 17, 2026
0db32ed
fix merge
ryanmitchell Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Jobs/ImportSingleProductJob.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,7 @@ private function buildVariantFields(): string
}
}
}
tracked
}'
: 'inventoryItem {
measurement {
Expand All @@ -387,6 +388,7 @@ private function buildVariantFields(): string
}
}
requiresShipping
tracked
}';

$contextualPricingFields = '';
Expand Down Expand Up @@ -571,7 +573,7 @@ private function importVariants(array $returnedVariants, string $product_slug, G
'product_slug' => $product_slug,
'title' => $variant['title'] === 'Default Title' ? 'Default' : $variant['title'],
'inventory_quantity' => $variant['inventoryQuantity'] ?? null,
'inventory_policy' => $variant['inventoryPolicy'] ?? null,
'inventory_policy' => Arr::get($variant, 'inventoryItem.tracked') ? ($variant['inventoryPolicy'] ?? null) : 'CONTINUE',
'inventory_management' => 'shopify', // @deprecated, left in for backwards JS compatibility
'price' => $variant['price'],
'compare_at_price' => $variant['compareAtPrice'],
Expand All @@ -591,7 +593,7 @@ private function importVariants(array $returnedVariants, string $product_slug, G
'price' => $variant['price'],
'compare_at_price' => $variant['compareAtPrice'],
'inventory_quantity' => $variant['inventoryQuantity'] ?? null,
'inventory_policy' => $variant['inventoryPolicy'] ?? null,
'inventory_policy' => Arr::get($variant, 'inventoryItem.tracked') ? ($variant['inventoryPolicy'] ?? null) : 'CONTINUE',
];

$existingMultiStoreData = $entry->get('multi_store_data', []);
Expand Down
45 changes: 44 additions & 1 deletion tests/Unit/ImportSingleProductJobTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,6 +464,48 @@ public function imports_product_when_in_sales_channel_and_filter_enabled()
$this->assertSame($entry->product_id, '108828309');
}

#[Test]
public function uses_shopify_inventory_policy_when_variant_is_tracked()
{
Facades\Collection::make(config('shopify.collection_handle', 'products'))->save();
Facades\Collection::make('variants')->save();
Facades\Taxonomy::make()->handle('collections')->save();
Facades\Taxonomy::make()->handle('tags')->save();
Facades\Taxonomy::make()->handle('type')->save();
Facades\Taxonomy::make()->handle('vendor')->save();

$this->mock(Graphql::class, function (MockInterface $mock) {
$mock->shouldReceive('query')->andReturn(new HttpResponse(status: 200, body: $this->getProductJson()));
});

Jobs\ImportSingleProductJob::dispatch(1);

$variant = Facades\Entry::whereCollection('variants')->first();
$this->assertSame('DENY', $variant->get('inventory_policy'));
}

#[Test]
public function sets_inventory_policy_to_continue_when_variant_is_not_tracked()
{
Facades\Collection::make(config('shopify.collection_handle', 'products'))->save();
Facades\Collection::make('variants')->save();
Facades\Taxonomy::make()->handle('collections')->save();
Facades\Taxonomy::make()->handle('tags')->save();
Facades\Taxonomy::make()->handle('type')->save();
Facades\Taxonomy::make()->handle('vendor')->save();

$json = str_replace('"tracked": true', '"tracked": false', $this->getProductJson());

$this->mock(Graphql::class, function (MockInterface $mock) use ($json) {
$mock->shouldReceive('query')->andReturn(new HttpResponse(status: 200, body: $json));
});

Jobs\ImportSingleProductJob::dispatch(1);

$variant = Facades\Entry::whereCollection('variants')->first();
$this->assertSame('CONTINUE', $variant->get('inventory_policy'));
}

private function getProductJson(): string
{
return '{
Expand Down Expand Up @@ -602,7 +644,8 @@ private function getProductJson(): string
"value": 0
}
},
"requiresShipping": true
"requiresShipping": true,
"tracked": true
},
"inventoryPolicy": "DENY",
"inventoryQuantity": 0,
Expand Down
Loading