Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| externalObjects: {} | ||
| userData: | ||
| assetBundleName: | ||
| assetBundleVariant: |
There was a problem hiding this comment.
Orphaned meta files for non-existent nested directories
Low Severity
Editor/Editor.meta and Runtime/Runtime.meta are folderAsset meta files for Editor/Editor/ and Runtime/Runtime/ subdirectories that don't exist. These appear to have been accidentally committed during the restructuring. Unity will log warnings about orphaned meta files, and auto-cleanup may cause unexpected git diffs for developers.
Additional Locations (1)
| *.bak | ||
| *.orig | ||
| *.swp | ||
| *~ |
There was a problem hiding this comment.
Gitignore *~ pattern silently ignores Samples~ directory
High Severity
The newly added *~ pattern in .gitignore matches any file or directory whose name ends with ~, which includes the Samples~ directory also introduced in this PR. While currently committed files are unaffected, any new untracked files added to Samples~/ in the future will be silently git-ignored. Developers won't see them in git status and git add will refuse them without -f. This directly undermines the UPM samples workflow this PR sets up. A negation rule like !Samples~ is needed.
Additional Locations (1)
1 participant
Note
Medium Risk
Medium risk because it restructures the Unity package into a UPM layout (new asmdefs, embedded dependency, moved/removed assets) and changes the release workflow to auto-commit version bumps before tagging, which can affect consumers and release automation if paths/assembly names are wrong.
Overview
Adds full UPM packaging for the Unity SDK. Introduces
Packages/gg.stash.unity/package.json(v2.0.0), newRuntime/andEditor/assembly definitions, package changelog/license, and updates Unity projectmanifest.json/packages-lock.jsonto includegg.stash.unityas an embedded package.Cleans up legacy Assets-based layout and docs. Removes old
Assets/Resourcesand variousAssets/Stash.Nativemetadata, updatesStashNativeto resolve the editor window type from the newStash.Unity.Editorassembly, and revisesREADME.mdto document UPM installation/sample import and updated iOS plugin paths.Adjusts release automation. The
release.ymlworkflow now rewritesPackages/gg.stash.unity/package.jsonversion to match the release input, commits/pushes that change when needed, then creates and pushes thevX.Y.Ztag.Written by Cursor Bugbot for commit e5637d2. This will update automatically on new commits. Configure here.