Use golangci-lint 2.x #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anisur Rahman <anisur@appscode.com>
There was a problem hiding this comment.
Pull request overview
This PR migrates the project to golangci-lint 2.x, which introduces a new configuration format and modern linting standards. The migration includes updating the Go version, simplifying the linting Makefile target, removing the old YAML linter configuration, and applying code style changes.
Key Changes
- Updated to golangci-lint 2.x with new configuration format in
.golangci.yml - Simplified linting Makefile command to use golangci-lint 2.x defaults
- Applied code rewrite rule changing
interface{}toany(Go 1.18+ alias)
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.golangci.yml |
Adds new golangci-lint 2.x configuration with standard linters, formatters, and gofmt rewrite rules |
Makefile |
Simplifies lint target by removing explicit flags that are now handled by .golangci.yml |
go.mod |
Updates Go version to 1.25.5 and removes toolchain directive |
lintconf.yaml |
Removes YAML linter configuration file (no longer needed) |
pkg/utils.go |
Applies interface{} to any rewrite rule as configured in the new golangci-lint setup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.