Skip to content

Added: Custom Constructor #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JasonHertzog wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Added: Custom Constructor #33

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2c62f84
Adding support for custom constructors
JasonHertzog Sep 24, 2023
b91cc17
Merge pull request #1 from JasonHertzog/custom-constructor
JasonHertzog Sep 24, 2023
004e7dd
Update code-generator.js
JasonHertzog Sep 24, 2023
4ac3faa
Added: Constructor will be a constructor instead of a method
JasonHertzog Sep 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions code-generator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ class JavaCodeGenerator {
* @param {type.Model} elem
* @param {Object} options
*/
writeConstructor (codeWriter, elem, options, imports, curPackage) {
writeConstructor (codeWriter, elem, options, imports, curPackage) {
if (elem.name.length > 0) {
var terms = []
// Doc
Expand Down Expand Up @@ -461,6 +461,7 @@ class JavaCodeGenerator {
var terms = []
var params = elem.getNonReturnParameters()
var returnParam = elem.getReturnParameter()
var isConstructor = (elem.name === owner.name)

// doc
var doc = elem.documentation.trim()
Expand Down Expand Up @@ -490,14 +491,10 @@ class JavaCodeGenerator {
}

// type
if (returnParam) {
if (returnParam && !isConstructor) {
terms.push(this.getType(returnParam, imports, curPackage))
} else {
if (elem.name === owner.name) {
//constructor has no return
}else{
terms.push('void')
}
} else if (!isConstructor) {
terms.push('void')
}

// name + parameters
Expand Down Expand Up @@ -528,7 +525,7 @@ class JavaCodeGenerator {
}

// return statement
if (returnParam) {
if (returnParam && !isConstructor) {
var returnType = this.getType(returnParam, imports, curPackage)
if (returnType === 'boolean') {
codeWriter.writeLine('return false;')
Expand Down