Skip to content

Conversation

@alon-f
Copy link
Contributor

@alon-f alon-f commented Jan 5, 2026

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

alon-f commented Jan 5, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@alon-f alon-f marked this pull request as ready for review January 5, 2026 12:25
@alon-f alon-f force-pushed the 01-05-add_column_log_size_print branch from 93c87d7 to 4cb8e73 Compare January 5, 2026 12:26
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.96%. Comparing base (0b81286) to head (5fb4ef5).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1303   +/-   ##
=======================================
  Coverage   92.95%   92.96%           
=======================================
  Files         115      115           
  Lines       14342    14355   +13     
  Branches    14342    14355   +13     
=======================================
+ Hits        13332    13345   +13     
  Misses        918      918           
  Partials       92       92           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alon-f alon-f force-pushed the 01-05-add_column_log_size_print branch from 4cb8e73 to 5fb4ef5 Compare January 5, 2026 12:28
Copy link
Collaborator

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gilbens-starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alon-f).


crates/stwo/src/prover/pcs/mod.rs line 336 at r1 (raw file):

    for (log_size, count) in log_size_histogram {
        info!("Log size {log_size}: {count}");
    }

Maybe add a title, "Column size histogram:" or something.

Suggestion:

    let mut log_size_histogram = HashMap::new();
    for column in columns {
        *log_size_histogram
            .entry(column.domain.log_size())
            .or_insert(0) += 1;
    }
    for (log_size, count) in log_size_histogram {
        info!("Log size {log_size}: {count}");
    }

@alon-f alon-f merged commit 738f85b into dev Jan 5, 2026
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants