feat: arena-based Copy expressions for BaseExpr and ExtExpr #1300
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Box<T>recursive variants with arena allocation usingu32indicesBaseExprandExtExprCopytypes, eliminating the need to manually.clone()every expression reuse in constraint definitionsParamvariants (StringIdinstead ofString)Motivation
When building AIR constraints, every reuse of an expression required manual
.clone()calls:Implementation
arena.rsmodule withExprArena, thread-local storage, and node typesBaseExpr(u32)andExtExpr(u32)are now just indices into the arena.node()method instead of direct enum accessBenefits
.clone()calls on expression reuseTest plan
--features prover