fix: Catch System.ObjectDisposedException when the request is already disposed#224
Open
cswpy wants to merge 1 commit intostardew-valley-dedicated-server:masterfrom
Open
fix: Catch System.ObjectDisposedException when the request is already disposed#224cswpy wants to merge 1 commit intostardew-valley-dedicated-server:masterfrom
cswpy wants to merge 1 commit intostardew-valley-dedicated-server:masterfrom
Conversation
2 tasks
cswpy
changed the title
cswpy
commented
Mar 4, 2026
Member
|
@cswpy change looks good, thanks :) Can you just update the commit message to something like edit: had to close and reopen your PR to trigger a fix in the CI on my side, and the failure for Label PR / Label PR (pull_request) can be ingored |
JulianVallee
approved these changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves #223 .
📚 Description
Do not attempt to access an already disposed Response object when a WebSocket request comes in and it fails during the process. After the change, this exception will be caught and not result in a warning any more.