Conversation
added 3 commits
April 27, 2025 14:37
- StarEditor will now prompt to open project on startup if no command line args are set - Fixed crash when editing already set script module class name - Added UI::ScopedStyleColor utility class
- Fixed crash when duplicating entities (entity name string memory would be moved and later referenced) - Delete key now deletes entities from scene + more - Moved Box2D body type conversion functions to new Physics2D header - Exposed Rigidbody2D body type Get/Set to C# API - Misc other fixes/changes
There was a problem hiding this comment.
Pull Request Overview
This PR introduces project functionality into the engine and editor, refactoring project handling and related integrations while adding new API methods to support these features.
- Added new project management functions in the EditorLayer and Project modules.
- Updated the ImGui layer to expose active widget IDs.
- Adjusted asset path handling in the Content Browser and Scene Hierarchy panels, and expanded math functionality in Vector2.
Reviewed Changes
Copilot reviewed 28 out of 31 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| StarEngine/src/StarEngine/ImGui/ImGuiLayer.h | Added GetActiveWidgetID API declaration. |
| StarEngine/src/StarEngine/ImGui/ImGuiLayer.cpp | Implemented GetActiveWidgetID using internal ImGui state. |
| StarEngine/src/StarEngine/Core/Application.cpp | Removed ScriptEngine initialization to defer it until project loading. |
| StarEngine/src/StarEngine.h | Included new Project header. |
| StarEngine-ScriptCore/Source/StarEngine/Vector2.cs | Added Length and LengthSquared methods. |
| StarEngine-ScriptCore/Source/StarEngine/Scene/Components.cs | Added BodyType enum and new properties for rigid body components. |
| StarEngine-ScriptCore/Source/StarEngine/InternalCalls.cs | Added internal project-related and physics interop calls. |
| StarEditor/src/Panels/SceneHierarchyPanel.cpp | Updated style handling and asset path resolution in drag-and-drop payload. |
| StarEditor/src/Panels/ContentBrowserPanel.h & .cpp | Added base directory handling and updated initialization from the Project system. |
| StarEditor/src/EditorLayer.h & .cpp | Introduced new project commands and integrated project loading with editor initialization. |
| StarEditor/SandboxProject/Assets/Scripts/Source/Player.cs | Modified Player component by removing the default Speed initialization. |
Files not reviewed (3)
- StarEditor/SandboxProject/Assets/Sandbox.starproj: Language not supported
- StarEditor/premake5.lua: Language not supported
- StarEngine/premake5.lua: Language not supported
Comments suppressed due to low confidence (1)
StarEditor/src/Panels/SceneHierarchyPanel.cpp:412
- Changing the drag-and-drop payload path calculation from a relative path (using the base asset directory) to a direct path may alter how textures are resolved. Ensure this update is aligned with the intended project structure.
std::filesystem::path texturePath(path);
| private RigidBody2DComponent m_RigidBody; | ||
|
|
||
| public float Speed = 1.0f; | ||
| public float Speed; |
There was a problem hiding this comment.
Removing the default initialization for 'Speed' may result in unintended behavior if the value is assumed to be non-zero elsewhere. Consider reintroducing a default value if one is expected.
Suggested change
| public float Speed; | |
| public float Speed = 5.0f; |
github-project-automation
bot
moved this from In Progress
to Done
in StarEngine Project Roadmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.