Skip to content

Default value of false was not working #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theprogrammerin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Default value of false was not working #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/rails_param/param.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ class MockController
def param!(name, type, options = {}, &block)
name = name.to_s unless name.is_a? Integer # keep index for validating elements

return unless params.member?(name) || options[:default].present? || options[:required]
return unless params.member?(name) || !options[:default].nil? || options[:required]

begin
params[name] = coerce(params[name], type, options)
params[name] = (options[:default].call if options[:default].respond_to?(:call)) || options[:default] if params[name].nil? and options[:default]
params[name] = (options[:default].call if options[:default].respond_to?(:call)) || options[:default] if params[name].nil? and !options[:default].nil?
params[name] = options[:transform].to_proc.call(params[name]) if params[name] and options[:transform]
validate!(params[name], name, options)

Expand Down
8 changes: 8 additions & 0 deletions spec/rails_param/param_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,14 @@ def params;
end
end

context "with a false value" do
it "defaults to the value" do
allow(controller).to receive(:params).and_return({})
controller.param! :word, :boolean, default: false
expect(controller.params["word"]).to eql(false)
end
end

context "with a block" do
it "defaults to the block value" do
allow(controller).to receive(:params).and_return({})
Expand Down