-
Notifications
You must be signed in to change notification settings - Fork 0
Implement 'aiofiles.os.walk' via a queue and generators #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Tinche, hello, could you review this PR, please? |
|
@stankudrow |
Thank you for the tip, I find it highly valuable. Did you mean that data races are possible because the I need a use case reproducing a problem because of this thread-unsafe nature of the UPD: there ase thread-safe versions of queue ADT, but this implementation deals with one consumer created each time the coroutine object gets instantiated. Is this the case? |
|
@Tinche , hello, I hope you are doing well. Now a thread-safe For now, I don't want to write a standalone |
@Tinche , @Martin005, are you happy with this PR? If so, it will be merged into this one ( Tinche#193 ) and will affect the PR into the I appreciate your time and I hope this work will be beneficial for the project itself. Feel free to share your ideas and propose commits - any coauthoring is welcome. Thank you. |
|
Stabilised, ready for reviewing. |
A queue-based solution for the aiofiles/PR-193 .