Skip to content

updated background animation for Hyper 2 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jcklpe wants to merge 1 commit into
base: master
Choose a base branch
from
Open

updated background animation for Hyper 2 #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const noise2Png = require('./noise2');
const noise3Png = require('./noise3');
const HUE_SHIFT_INTENSITY = 4;
const BRIGHT_GREEN = '#28FC91';
const DARK_GREEN = '#0F2218';
const DARK_GREEN = 'transparent';
Copy link
Copy Markdown
Owner

@staltz staltz Jul 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thedonquixotic Exciting that this is your first PR! :)
Could you update it to avoid changing the value of DARK_GREEN? Instead, wherever we use DARK_GREEN, replace it with transparent.

Copy link
Copy Markdown
Owner

@staltz staltz Jul 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For instance on line 12 and 68 we should use transparent instead

const TEXT_GREEN = '51, 255, 0';

exports.decorateConfig = (config) => {
Expand Down Expand Up @@ -41,10 +41,19 @@ exports.decorateHyper = (HyperTerm, { React, notify }) => {
const textShadow = generateTextShadow();

const overridenProps = {
backgroundColor: 'black',
backgroundColor: 'transparent',
customCSS: `
${this.props.customCSS || ''}
body {
.hyper_main {
${noiseCss}
}
.term_fit {
${noiseCss}
}
.term_wrapper {
${noiseCss}
}
.xterm_screen {
${noiseCss}
}
.tabs_nav {
Expand Down