Hephaestus Forge fix for removing items#484
Open
NicolasFlamel42 wants to merge 1 commit intostal111:1.19.2from
Open
Hephaestus Forge fix for removing items#484NicolasFlamel42 wants to merge 1 commit intostal111:1.19.2from
NicolasFlamel42 wants to merge 1 commit intostal111:1.19.2from
Conversation
… already fixed in later versions
Owner
|
@NicolasFlamel42 Do you still need this fix for the 1.19.2 version? |
|
@NicolasFlamel42 thanks for your PR, I also merged it to my 1.20.1 fork and opened a PR for 1.20.1 with your fix |
|
@stal111 Hey I messaged you on your Discord, but got no answer as of today. We were busy with other things, mainly Work and University and paused our development. We are back at it now and we really need that fix in 1.19.2, because our mod pack is to far into devolpment to change the version now. Sorry that we took so long to answer. Could you please release our fix on curse and modrinth so we can use the fixed version in our modpack, that would be great. Ty |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an item gets removed from the pedestals, while the Forge is crafting it now fails the ritual, fixing an exploit for free crafts.
This was already fixed for later versions, but since I need this in 1.19.2, here is the "backport" of the fix.