-
Notifications
You must be signed in to change notification settings - Fork 18
Optimize standalone Docker build time #398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Chiamaka489
wants to merge
5
commits into
stakwork:main
Choose a base branch
from
Chiamaka489:optimize-standalone-docker-build
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
bb95f05
optimize: reduce Docker build time
Chiamaka489 1c5676c
Merge remote-tracking branch 'origin' into optimize-standalone-docker…
Chiamaka489 7a45561
Merge remote-tracking branch 'origin' into optimize-standalone-docker…
Chiamaka489 e5a1a65
clean code
Chiamaka489 48d6993
feat(ci): optimize Docker build with multi-platform support (ARM64/AM…
Chiamaka489 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,40 +1,57 @@ | ||
| name: Build and Publish Standalone Docker Image | ||
|
|
||
| name: Build and Publish Stakgraph Standalone | ||
| on: | ||
| release: | ||
| types: [published] | ||
| push: | ||
| branches: | ||
| - main | ||
| paths: | ||
| - "standalone/**" | ||
| - "ast/**" | ||
| - "lsp/**" | ||
| - "Dockerfile.standalone" | ||
|
|
||
| jobs: | ||
| build-and-push: | ||
| build-and-publish: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| packages: write | ||
|
|
||
| name: Build and Publish Docker Image | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v3 | ||
|
|
||
| - name: Log in to GitHub Container Registry | ||
| - name: Login to GitHub Container Registry | ||
| uses: docker/login-action@v3 | ||
| with: | ||
| registry: ghcr.io | ||
| username: ${{ github.actor }} | ||
| password: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Build and push Docker image | ||
| # Setup cache | ||
| - name: Cache Docker layers | ||
| uses: actions/cache@v3 | ||
| with: | ||
| path: /tmp/.buildx-cache | ||
| key: ${{ runner.os }}-buildx-${{ github.sha }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-buildx- | ||
|
|
||
| # Build and push the image | ||
| - name: Build and Push Docker Image | ||
| uses: docker/build-push-action@v5 | ||
| with: | ||
| context: . | ||
| file: Dockerfile.standalone | ||
| platforms: linux/amd64,linux/arm64 | ||
| file: ./Dockerfile.standalone | ||
| push: true | ||
| # Use registry cache which is more reliable for multi-platform | ||
| cache-from: type=registry,ref=ghcr.io/stakwork/stakgraph-standalone:buildcache | ||
| cache-to: type=registry,ref=ghcr.io/stakwork/stakgraph-standalone:buildcache,mode=max | ||
| tags: | | ||
| ghcr.io/stakwork/stakgraph-standalone:${{ github.ref_name }} | ||
| ghcr.io/stakwork/stakgraph-standalone:latest | ||
| ghcr.io/stakwork/stakgraph-standalone:${{ github.sha }} | ||
| cache-from: type=local,src=/tmp/.buildx-cache | ||
| cache-to: type=local,dest=/tmp/.buildx-cache-new,mode=max | ||
| platforms: linux/amd64,linux/arm64 | ||
| build-args: | | ||
| BUILDKIT_INLINE_CACHE=1 | ||
| - name: Move cache | ||
| run: | | ||
| rm -rf /tmp/.buildx-cache | ||
| mv /tmp/.buildx-cache-new /tmp/.buildx-cache | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did u change the platform? i want it to run on my m4 and also on amd in the cloud
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Evanfeenstra Fixed