feat(view): add grep and glob parameters for content search and file … #472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…filtering - Add grep parameter for regex content search in files/directories - Add glob parameter for filtering files by pattern in directories - Support combined grep+glob: filter files by glob, then search content - Use ripgrep ecosystem (grep-regex, grep-searcher, ignore, globset) for local search - Remote search uses grep -E for extended regex support - Fix shell escaping for remote commands with special characters (|, $, etc.) - Update TUI to display grep/glob parameters in view blocks - Show 'Grep', 'Glob', or 'Grep+Glob' title based on operation type Local search respects .gitignore automatically via ignore crate. Remote search uses find + grep -E for glob+grep combinations.
- Remove unused extract_file_path_from_tool_call function - Refactor view_remote_path to use ViewOptions struct (reduces args from 9 to 4)
- Reduces view_local_path args from 8 to 3 - Consistent pattern with view_remote_path
mstfash
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local search respects .gitignore automatically via ignore crate. Remote search uses find + grep -E for glob+grep combinations.