-
Notifications
You must be signed in to change notification settings - Fork 100
Release 0.3.12 #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ahmedhesham6
wants to merge
52
commits into
main
Choose a base branch
from
beta
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Release 0.3.12 #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed a bug where if the content is empty it returns an emtpy HashMap
Converted SecretManager to an actor-based architecture for improved thread-safety with benchmarks
… password leak in logs
- replace String with bytes to avoid clones - use `choose()` to simplify getting random bytes
Remove content parameter from `redact_password()`. Unlike `redact_secrets()` which scans content, this function now only redacts CSPRNG-generated passwords.
Add `MAX_RETRIES` const to control password generation retry attempts when conflicts are detected
Add validation in `Password::new()` to reject passwords shorter than 8 characters with `TooShort` error.
…rate_password` fn
password conflicts are extremely rare so no need for all that verbosity logging
The `Password` type ensures that passwords cannot be empty, making explicit empty checks unnecessary
Update `redact_password()` to accept the new `Password` type instead of String
The caller `redact_and_store_secrets_impl` uses `extend()` to merge results, so returning the full cloned map caused redundancy as we already have the old mappings.
…wrds refactor: optimize secret redaction and preserve redaction maps
…tegration-example Feature/add rust mcp client integration example
feat: add actor model to `SecretManager` for redaction map thread safety
Feature/improve password security
This commit removes redundant secret handling logic from `local_tools.rs`. The `SecretManager` is now responsible for handling secrets at a higher level, eliminating the need for these duplicate calls within the local tools.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.