Conversation
…added comments to targetrunner
… to specify the problem directory path containing the generator, model, and repair, rather than specifying each individual path. Right now it only works with essence problems but I can easily make it work with mzn problems as well. Only rule is that the problem needs to be called problem.essence, the generator generator.essence, and repair file repair.essence
This reverts commit 3aff897.
…nly need to specify the problem directory path containing the generator, model, and repair, rather than specifying each individual path. Right now it only works with essence problems but I can easily make it work with mzn problems as well. Only rule is that the problem needs to be called problem.essence, the generator generator.essence, and repair file repair.essence" This reverts commit 9328e76.
Contributor
|
@spritezs: thank you for the PR. There are a number of issues that I think we'd need to address before merging:
I had a discussion with Oz last Wednesday, and it seems that the best solution is to make a fresh fork of the current dev branch on your own github account, do the changes that related to this functionality, and create a PR with that fork. It'd be helpful if you could summary the list of changes when submitting the new PR too. Could you please help try that again? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created new branch and removed heavy files from pr. Only left install-savilerow.sh in the bin dir since that's the only one I ve changed.