Skip to content

Conversation

@diujin
Copy link
Contributor

@diujin diujin commented Feb 21, 2025

What is this PR for?

  • Just updating content and/or documentation
  • This fixes issue Loader Absolute hangs in windows. #6 _____
  • Spot fix (no issue #)
  • Merging WIP feature #_____
  • Merging done feature #_____
  • This is a merge from a version branch
  • Adding/Updating tests
  • This is a conflict resolution
  • This is a branch cleanup
  • Other: ________________

I verify that...

  • I have logged my time in the commits
  • I have logged my time in this PR
  • I have tagged all the relevant issues
  • I am using VS Code for type checks and linting, or
  • I have ran npm run test with no errors
  • I have manually checked that this bug or feature is working

Copy link
Member

@cblanquera cblanquera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution is acceptable, but please note the tabbing mistake on this commit. I'll fix it on the next commit.

@cblanquera cblanquera merged commit 637fe98 into stackpress:main Feb 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants