Switch to cgroup for job control and associated settings#205
Merged
Conversation
- switching ProctrackType to proctrack/cgroup, which is the recommended setting (was disabled for CI) - Enabling TaskPlugins task/cgroup,task/affinity to bind jobs to allocated cpuset - SelectTypeParameters=CR_Core_Memory to also limit memory
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly enables cgroup-based process tracking and resource management for Slurm by updating the default configuration. The addition of Molecule tests to verify the cgroup limits is a valuable improvement. My review focuses on improving the new tests' robustness and maintainability. I've identified a bug in a test failure message, some fragile logic that relies on globbing, and opportunities to make the tests more readable by naming tasks.
elelaysh
force-pushed
the
feat/enable_cgroup
branch
6 times, most recently
from
7b7ead8 to
75a63f0
Compare
elelaysh
force-pushed
the
feat/enable_cgroup
branch
from
75a63f0 to
f814726
Compare
enable cpuset for whole user.slice hierarchy
in cgroup. So that we can enable the cpuset controller for it.
elelaysh
force-pushed
the
feat/enable_cgroup
branch
from
f814726 to
dea53ca
Compare
elelaysh
changed the title
Contributor
Author
|
ready for review |
elelaysh
commented
Jan 26, 2026
sjpb
requested changes
Feb 5, 2026
Co-authored-by: Steve Brasier <33413598+sjpb@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProctrackTypetoproctrack/cgroup, which is the recommended setting(was disabled for compatibility with CI running in containers)
TaskPlugin=task/cgroup,task/affinityto bind jobs to allocated CPUsJobAcctGatherType=jobacct_gather/cgroupinstead ofjobacct_gather/linux