Skip to content

Conversation

@MiceHelium
Copy link

PBS v3.0.11

Added a setting to only show videos greater than a user-determined length in minutes (Defaults to 0).

I'm new to github so if I messed this up badly, please let me know.

PBS, by default releases a series of clips with some of their programs such as NOVA, Nature, and Frontline that are often part of the feature episode. In my experience these clips just cause clutter and get in the way of finding the full episode, especially with skins that don't display the video length in a conspicuous manner.

PBS v3.0.11

Added a setting to only show videos greater than a user-determined length
@stacked
Copy link
Owner

stacked commented Jan 17, 2014

Hey MiceHelium,

I thought about doing something like this, but some videos are returned by the API without a time stamp.

As an alternative, it would probably be a better idea to exclude clips in the API request.

For example:
exclude_type__in='Chapter,Promotion,Segment,Clip'
or
filter_type='Episode'

can be added to lines 197 and 211.

Note: Please clone the latest commit before making changes. Your edits was done on v3.0.10 instead of v3.0.11

@MiceHelium
Copy link
Author

Thank you for the feedback.

I now realize how naive my intentions were and will avoid proposing cheap hacks as a solution in the future.

Taking preference for different video types over length makes a lot more sense and will surely provide cleaner results.

Thank you for taking the time to respond.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants