Skip to content

feat: add support for the client spooling protocol#793

Merged
razvan merged 41 commits intomainfrom
issues/673
Sep 17, 2025
Merged

feat: add support for the client spooling protocol#793
razvan merged 41 commits intomainfrom
issues/673

Conversation

@razvan
Copy link
Copy Markdown
Member

@razvan razvan commented Sep 2, 2025 •
edited
Loading

Description

Part of github.com//issues/763
Depends on decision: https://github.com/stackabletech/decisions/issues/60

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@razvan razvan self-assigned this Sep 2, 2025
@razvan razvan marked this pull request as ready for review September 4, 2025 16:09
@razvan razvan requested a review from a team September 4, 2025 16:09
sbernauer
sbernauer reviewed Sep 4, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice feature! :)
I only looked at the CRD code as part of the decision

@razvan razvan requested a review from sbernauer September 5, 2025 09:20
@razvan razvan mentioned this pull request Sep 5, 2025
Closed
20 tasks
@razvan razvan requested a review from sbernauer September 16, 2025 14:57
sbernauer
sbernauer previously approved these changes Sep 17, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Getting close to merge

@razvan @sbernauer
Apply suggestions from code review
f7f1e95 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
sbernauer
sbernauer previously approved these changes Sep 17, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a small snafu error remaining

@razvan razvan requested a review from sbernauer September 17, 2025 08:29
@razvan razvan enabled auto-merge September 17, 2025 08:31
sbernauer
sbernauer approved these changes Sep 17, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks! And sorry for refactoring existing code 🙈

@razvan razvan added this pull request to the merge queue Sep 17, 2025
Merged via the queue into main with commit 66c6837 Sep 17, 2025
17 checks passed
@razvan razvan deleted the issues/673 branch September 17, 2025 08:47
@razvan
Copy link
Copy Markdown
Member Author

razvan commented Sep 17, 2025

Release note

The Trino client spooling protocol can now be configured using the spec.clusterConfig.clientProtocol.spooling property. Users can configure an S3 connection and the location or spooling segments. Additional properties can be added using the configOverrides mechanism for the spooling-manager.properties file.

@razvan razvan moved this from Development: In Review to Development: Done in Stackable Engineering Sep 17, 2025
@razvan razvan added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 17, 2025
@lfrancke
Copy link
Copy Markdown
Member

lfrancke commented Sep 22, 2025

Could you please add links to docs?

@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Sep 22, 2025
@sbernauer
Copy link
Copy Markdown
Member

sbernauer commented Sep 22, 2025

https://docs.stackable.tech/home/nightly/trino/usage-guide/client-spooling-protocol/

@lfrancke lfrancke moved this from Acceptance: In Progress to Done in Stackable Engineering Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

@razvan razvan

Labels

release/25.11.0 release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@razvan @lfrancke @sbernauer