Conversation
sbernauer
approved these changes
Mar 13, 2025
Member
There was a problem hiding this comment.
Code change LGTM, thanks for fixing this!
Looking at
trino-operator/tests/test-definition.yaml
Lines 107 to 109 in b43f8e1
opa-authorization test for all supported Trino versions and not only the latest (think e.g. of LTS users). Especially as this is security-related and we have many Trino users.
However, I know that this requires a bit of jinja templating based on the Trino version.
Not blocking the PR on this though
Member
Author
I can look at it in a follow-up (or someone else if interested), thanks 👍 |
Member
|
Also checked on OpenShift :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Integration test had errors:
Caused by: software.amazon.awssdk.services.s3.model.S3Exception: Missing required header for this request: Content-Md5-> fixed by minio version bump Support AWS S3 new checksums minio/minio#20845 (comment)optimize_hash_generationwas removed in Trino 470 https://trino.io/docs/current/release/release-470.htmlAssertionError: Regex pattern did not match. Regex: "Session property 'iceberg.test' does not exist"Definition of Done Checklist