test(metrics): Use unique names for cluster-wide Prometheus resources

[siegfriedweber]

Description

Use unique names for cluster-wide Prometheus resources

Prometheus was installed with the Helm paramter --take-ownership which should have prevented the following error, but it did not:

Error: INSTALLATION FAILED: 3 errors occurred:
    * clusterroles.rbac.authorization.k8s.io "prometheus-stack-kube-prom-prometheus" already exists
    * clusterrolebindings.rbac.authorization.k8s.io "prometheus-stack-kube-prom-prometheus" already exists
    * mutatingwebhookconfigurations.admissionregistration.k8s.io "prometheus-stack-kube-prom-admission" already exists

Therefore, the namespace is now added to the Helm release name and in turn to the cluster-wide resources.

Definition of Done Checklist

• Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
• Please make sure all these things are done and tick the boxes

Author

• Changes are OpenShift compatible
• Integration tests passed (for non trivial changes)

Reviewer

• Code contains useful comments
• Code contains useful logging statements
• (Integration-)Test cases added
• Documentation added or updated. Follows the style guide.
• Changelog updated
• Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

• Feature Tracker has been updated
• Proper release label has been added
• Links to generated (nightly) docs added
• Release note snippet added
• Add type/deprecation label & add to the deprecation schedule
• Add type/experimental label & add to the experimental features tracker

[xeniape]

• Is the assert of Prometheus starting up no longer needed?
• The test fails locally for me, a ServiceMonitor is created a step earlier than Prometheus being installed (which has the ServiceMonitor CRD)

[siegfriedweber]

The test fails locally for me, a ServiceMonitor is created a step earlier than Prometheus being installed (which has the ServiceMonitor CRD)

Argh. I should have tested the change in a fresh Kubernetes cluster.

Is the assert of Prometheus starting up no longer needed?

helm install ... --wait waits until all resources are in a ready state. Therefore, the assertion was never required. I removed it because the StatefulSet is now also suffixed with the namespace and this cannot be expressed in the assertion.

[xeniape]

Passes now 👍 thanks :)