Skip to content

chore: Use anchors in regular expressions#102

Merged
siegfriedweber merged 1 commit intomainfrom
chore/fix-regexes
Jan 22, 2026
Merged

chore: Use anchors in regular expressions#102
siegfriedweber merged 1 commit intomainfrom
chore/fix-regexes

Conversation

@siegfriedweber
Copy link
Copy Markdown
Member

Description

Use the anchors ^ and $ in regular expressions

In stackable-operator and in the Kubernetes source code, there are formats (fmt), e.g. [a-z]([-a-z0-9]*[a-z0-9])?, and regular expressions (regex), e.g. ^[a-z]([-a-z0-9]*[a-z0-9])?$. The format is without anchors and the regular expression contains the anchors (if desired).

This is now applied to the regular expressions in this operator.

The constants from stackable-operator are not used anymore because strings cannot be concatenated at compile-time. This would be possible with a macro like concatcp but I chose, not to introduce another dependency.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Integration tests passed (for non trivial changes)

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@siegfriedweber siegfriedweber self-assigned this Jan 21, 2026
@siegfriedweber siegfriedweber moved this to Development: Waiting for Review in Stackable Engineering Jan 21, 2026
Copy link
Copy Markdown
Member

@labrenbe labrenbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@siegfriedweber siegfriedweber added this pull request to the merge queue Jan 22, 2026
@siegfriedweber siegfriedweber moved this from Development: Waiting for Review to Development: Done in Stackable Engineering Jan 22, 2026
Merged via the queue into main with commit f7890c9 Jan 22, 2026
12 checks passed
@siegfriedweber siegfriedweber deleted the chore/fix-regexes branch January 22, 2026 07:41
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants