Merged
Conversation
sbernauer
previously approved these changes
Jul 25, 2025
Member
sbernauer
left a comment
There was a problem hiding this comment.
Puhhhh....
Please have a look at the linter failures and decide if we want to ignore them
sbernauer
previously approved these changes
Jul 25, 2025
Member
sbernauer
left a comment
There was a problem hiding this comment.
I let you decide on the linting
sbernauer
previously approved these changes
Jul 25, 2025
Member
sbernauer
left a comment
There was a problem hiding this comment.
I let you decide on the linting
Member
Author
Thanks! I decided to do it to keep the checks clean (and hadn't realised pre-commit was not activated locally) |
sbernauer
approved these changes
Jul 25, 2025
Member
sbernauer
left a comment
There was a problem hiding this comment.
Thanks!
I was not sure how much was generated content from the helm-chart
adwk67
added a commit
that referenced
this pull request
Jul 25, 2025
* fix(test): Iceberg/Minio on openshift * linting * more linting * more linting * linting, finally turned on pre-commit locally
adwk67
added a commit
that referenced
this pull request
Jul 25, 2025
fix(test): Iceberg/Minio on openshift (#827) * fix(test): Iceberg/Minio on openshift * linting * more linting * more linting * linting, finally turned on pre-commit locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test did not work on Openshift
Tests:
Openshift:
kinD:
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker