Skip to content

chore: Fix tests, partially by fixing reporting-task#818

Merged
NickLarsenNZ merged 4 commits intomainfrom
test/fix-tests
Jul 14, 2025
Merged

chore: Fix tests, partially by fixing reporting-task#818
NickLarsenNZ merged 4 commits intomainfrom
test/fix-tests

Conversation

@sbernauer
Copy link
Copy Markdown
Member

@sbernauer sbernauer commented Jul 14, 2025 •
edited
Loading

Description

The reporting task (nifi 1 only) mounted a wrong secret-operator volume, fixed this.
Also, lot's of random test fixes needed

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@NickLarsenNZ NickLarsenNZ mentioned this pull request Jul 14, 2025
Closed
13 tasks
@sbernauer sbernauer marked this pull request as ready for review July 14, 2025 11:59
@sbernauer sbernauer self-assigned this Jul 14, 2025
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Jul 14, 2025
maltesander
maltesander approved these changes Jul 14, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer
Copy link
Copy Markdown
Member Author

sbernauer commented Jul 14, 2025

Started https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/nifi-operator-it-custom/62/

@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jul 14, 2025
@NickLarsenNZ
Copy link
Copy Markdown
Member

NickLarsenNZ commented Jul 14, 2025 •
edited
Loading

The tests passed

--- PASS: kuttl (4079.55s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/ldap_nifi-1.27.0_zookeeper-latest-3.9.3_ldap-use-tls-false_openshift-false (293.43s)
        --- PASS: kuttl/harness/cluster_operation_nifi-latest-2.4.0_zookeeper-latest-3.9.3_openshift-false (156.90s)
        --- PASS: kuttl/harness/iceberg_nifi-iceberg-2.4.0_zookeeper-latest-3.9.3_opa-l-1.4.2_hdfs-l-3.4.1_hive-l-4.0.1_trino-l-476_krb5-1.21.1_iceberg-use-kerberos-false_kerberos-realm-PROD.MYCORP_openshift-false (575.06s)
        --- PASS: kuttl/harness/oidc-opa_nifi-2.4.0_zookeeper-latest-3.9.3_opa-l-1.4.2_oidc-use-tls-true_openshift-false (262.19s)
        --- PASS: kuttl/harness/oidc-opa_nifi-2.4.0_zookeeper-latest-3.9.3_opa-l-1.4.2_oidc-use-tls-false_openshift-false (226.61s)
        --- PASS: kuttl/harness/oidc-opa_nifi-1.28.1_zookeeper-latest-3.9.3_opa-l-1.4.2_oidc-use-tls-true_openshift-false (348.48s)
        --- PASS: kuttl/harness/oidc-opa_nifi-1.28.1_zookeeper-latest-3.9.3_opa-l-1.4.2_oidc-use-tls-false_openshift-false (311.77s)
        --- PASS: kuttl/harness/oidc-opa_nifi-1.27.0_zookeeper-latest-3.9.3_opa-l-1.4.2_oidc-use-tls-true_openshift-false (227.98s)
        --- PASS: kuttl/harness/logging_nifi-2.4.0_zookeeper-latest-3.9.3_openshift-false (72.42s)
        --- PASS: kuttl/harness/oidc-opa_nifi-1.27.0_zookeeper-latest-3.9.3_opa-l-1.4.2_oidc-use-tls-false_openshift-false (259.17s)
        --- PASS: kuttl/harness/logging_nifi-1.28.1_zookeeper-latest-3.9.3_openshift-false (103.99s)
        --- PASS: kuttl/harness/logging_nifi-1.27.0_zookeeper-latest-3.9.3_openshift-false (115.31s)
        --- PASS: kuttl/harness/ldap_nifi-2.4.0_zookeeper-latest-3.9.3_ldap-use-tls-true_openshift-false (166.29s)
        --- PASS: kuttl/harness/smoke_v2_nifi-v2-2.4.0_use-zookeeper-manager-true_zookeeper-3.9.3_openshift-false_listener-class-external-unstable (179.25s)
        --- PASS: kuttl/harness/smoke_v2_nifi-v2-2.4.0_use-zookeeper-manager-true_zookeeper-3.9.3_openshift-false_listener-class-cluster-internal (141.00s)
        --- PASS: kuttl/harness/smoke_v2_nifi-v2-2.4.0_use-zookeeper-manager-false_zookeeper-3.9.3_openshift-false_listener-class-external-unstable (143.08s)
        --- PASS: kuttl/harness/smoke_v2_nifi-v2-2.4.0_use-zookeeper-manager-false_zookeeper-3.9.3_openshift-false_listener-class-cluster-internal (134.70s)
        --- PASS: kuttl/harness/external-access_nifi-1.28.1_zookeeper-latest-3.9.3_openshift-false (93.49s)
        --- PASS: kuttl/harness/ldap_nifi-1.28.1_zookeeper-latest-3.9.3_ldap-use-tls-false_openshift-false (191.52s)
        --- PASS: kuttl/harness/orphaned_resources_nifi-2.4.0_zookeeper-latest-3.9.3_openshift-false (107.26s)
        --- PASS: kuttl/harness/orphaned_resources_nifi-1.28.1_zookeeper-latest-3.9.3_openshift-false (147.93s)
        --- PASS: kuttl/harness/resources_nifi-2.4.0_zookeeper-latest-3.9.3_openshift-false (85.40s)
        --- PASS: kuttl/harness/orphaned_resources_nifi-1.27.0_zookeeper-latest-3.9.3_openshift-false (209.11s)
        --- PASS: kuttl/harness/resources_nifi-1.28.1_zookeeper-latest-3.9.3_openshift-false (165.35s)
        --- PASS: kuttl/harness/resources_nifi-1.27.0_zookeeper-latest-3.9.3_openshift-false (153.28s)
        --- PASS: kuttl/harness/external-access_nifi-2.4.0_zookeeper-latest-3.9.3_openshift-false (66.80s)
        --- PASS: kuttl/harness/ldap_nifi-1.27.0_zookeeper-latest-3.9.3_ldap-use-tls-true_openshift-false (177.14s)
        --- PASS: kuttl/harness/upgrade_nifi_old-1.27.0_nifi_new-2.4.0_zookeeper-latest-3.9.3_openshift-false (357.97s)
        --- PASS: kuttl/harness/ldap_nifi-2.4.0_zookeeper-latest-3.9.3_ldap-use-tls-false_openshift-false (164.59s)
        --- PASS: kuttl/harness/ldap_nifi-1.28.1_zookeeper-latest-3.9.3_ldap-use-tls-true_openshift-false (194.01s)
        --- PASS: kuttl/harness/smoke_v1_nifi-v1-1.27.0_zookeeper-3.9.3_openshift-false_listener-class-cluster-internal (216.12s)
        --- PASS: kuttl/harness/smoke_v1_nifi-v1-1.28.1_zookeeper-3.9.3_openshift-false_listener-class-cluster-internal (235.85s)
        --- PASS: kuttl/harness/smoke_v1_nifi-v1-1.28.1_zookeeper-3.9.3_openshift-false_listener-class-external-unstable (225.04s)
        --- PASS: kuttl/harness/external-access_nifi-1.27.0_zookeeper-latest-3.9.3_openshift-false (92.14s)
        --- PASS: kuttl/harness/smoke_v1_nifi-v1-1.27.0_zookeeper-3.9.3_openshift-false_listener-class-external-unstable (239.42s)
        --- PASS: kuttl/harness/custom-components-git-sync_nifi-1.28.1_zookeeper-latest-3.9.3_openshift-false (172.49s)
        --- PASS: kuttl/harness/custom-components-git-sync_nifi-2.4.0_zookeeper-latest-3.9.3_openshift-false (202.05s)
        --- PASS: kuttl/harness/custom-components-git-sync_nifi-1.27.0_zookeeper-latest-3.9.3_openshift-false (150.90s)
        --- PASS: kuttl/harness/iceberg_nifi-iceberg-2.4.0_zookeeper-latest-3.9.3_opa-l-1.4.2_hdfs-l-3.4.1_hive-l-4.0.1_trino-l-476_krb5-1.21.1_iceberg-use-kerberos-true_kerberos-realm-PROD.MYCORP_openshift-false (447.39s)
PASS

@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Jul 14, 2025
Merged via the queue into main with commit 9566549 Jul 14, 2025
17 checks passed
@NickLarsenNZ NickLarsenNZ deleted the test/fix-tests branch July 14, 2025 14:51
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Jul 14, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maltesander maltesander maltesander approved these changes

Assignees

@sbernauer sbernauer

Labels

None yet

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sbernauer @NickLarsenNZ @maltesander @lfrancke