Skip to content

Fix thumbnail issues#69

Draft
m-mohr wants to merge 1 commit intomainfrom
fix-thumbnail
Draft

Fix thumbnail issues#69
m-mohr wants to merge 1 commit intomainfrom
fix-thumbnail

Conversation

@m-mohr
Copy link
Copy Markdown
Collaborator

@m-mohr m-mohr commented Oct 2, 2023

  • Add missing await
  • Correctly parse bbox if it has 6 elements
  • pass img instead of url

ToDo: Check why images get shown too large

@DanielJDufour
Copy link
Copy Markdown
Member

Changes look good. I'm not sure it'll completely solve the smearing, but it's a big step in the right direction :-)

@StijnCaerts
Copy link
Copy Markdown

Can this be merged? I think this may cause thumbnails not to be rendered on an Item in stac-browser if they are not the first 'candidate'.

@m-mohr
Copy link
Copy Markdown
Collaborator Author

m-mohr commented Feb 27, 2024

No, there's still the open question: "Check why images get shown too large"

Also, merging this won't be available in STAC Browser unless someone works on a PR to upgrade from stac-layer 0.15 to 1.0 (or provides funding to STAC Browser and this library).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants