This repository was archived by the owner on Mar 18, 2021. It is now read-only.
Fix non ssl connection in aqueduct db upgrade even if --use-ssl is used. #894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joeconwaystk what do you think about this PR? Something that could be merged soon? :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cli command aqueduct db upgrade was not able to connect to SSL only postgres instances while running migration scripts. Issue #811
This PR changes src/cli/scripts/run_upgrade.dart -> RunUpgradeExecutable.execute to use SSL if --use-ssl is used while aqueduct db upgrade.