This repository was archived by the owner on Jun 11, 2021. It is now read-only.
see #68: enhanced 'Binding' with varargs argument for routingKeys and… #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ys and bind each routingKey when processing 'AddBinding' message
Owner
|
I'll have a closer look asap (this weekend at the latest) but it looks good! |
Author
|
Hi. Any news on the status of this PR? :) |
Owner
|
Hi! Sorry it took so long, I was extremely busy on another project and fell behind. It looks ok, and I'm ready to merge. I would be nice to add a basic test, and also to port your changes to the scala2.10 branch (which I'll probably stop maintaining soon after scala 2.12 is released). I can take care of that (test + scala 2.10). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… bind each routingKey when processing 'AddBinding' message