Conversation
remove deleted data field from CollectionEntriesGetResponse and CollectionEntriesQueryResponse
|
Hi, first thank you for the good job :-). I only miss the uris property when adding records... |
Hi @inlineHamed, After spending a bit of time away from the project I'll be checking the pull request you posted. Regarding Unit Tests - these are mandatory, but I'll get myself familiar with the changes you made while focusing on the APIs available in the Chroma V2, to see if there are any missing functionalities or features which changed significantly until this moment. |
|
@ssone95 you're welcome |
Yes, and it makes sense - but that's something I plan to discuss with @cincuranet as we'll need to work on (potentially full) Chroma V2 support, and that involves other features it brings us, so we may need to change the way some of these work. At the moment - this patch looks good, but we can't merge it yet until we get to decide how we'll handle other things related to V2. |

I've updated ChromaClient and ChromaCollectionClient, with most of the work done by DeepSeek. I believe there's an error in the Chroma Swagger documentation regarding working with collections in API v2 2 api: chroma-core/chroma#4456

For now, I have implemented these two changes in a way that they work.
79 tests passed, but some failed—I have no idea why, and I don't have more time to investigate: