Fix/prometheus metrics registration edge case bug#13
Closed
amirhnajafiz wants to merge 5 commits intossmirr:masterfrom
Closed
Fix/prometheus metrics registration edge case bug#13amirhnajafiz wants to merge 5 commits intossmirr:masterfrom
amirhnajafiz wants to merge 5 commits intossmirr:masterfrom
Conversation
Author
|
@ssmirr Please sync the latest changes from |
amirhnajafiz
deleted the
fix/prometheus-metrics-registration-edge-case-bug
branch
Owner
|
Sorry it took me a while to get back to review and merge this one, and thanks for letting me know this is now fixed in upstream! I'm going to pull all latest changes from upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChangeLog
MustRegisterwithRegisterfor safe and dynamic metric registration.Why?