Draft
Conversation
…n with a deliver invocation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #716 +/- ##
==========================================
- Coverage 98.35% 96.77% -1.59%
==========================================
Files 30 31 +1
Lines 2190 2232 +42
==========================================
+ Hits 2154 2160 +6
- Misses 36 72 +36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR represents a sketch of how we might implement a results catalog feature for local caches of ServiceX results.
Concepts:
.servicexdirectory that provides the metadata for each runSample Versions
In order to facilitate working with multiple runs of a sample, we introduce a version property for each sample run. This optional property can be set with the new
--versionCLI option for thedelivercommand. This string is also now an argument for thedeliverfunction inservicex_client.Notes:
Generalsection of the spec so it can be tied to source code controlExample
I created cat_demo.py in examples directory to show how this works: