Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #702 +/- ##
==========================================
+ Coverage 98.35% 98.38% +0.03%
==========================================
Files 30 31 +1
Lines 2191 2234 +43
==========================================
+ Hits 2155 2198 +43
Misses 36 36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
servicex/app/check.py
Outdated
| results = {} | ||
|
|
||
| async def wrapped_verify_token(endpoint): | ||
| result = await verify_token(endpoint.endpoint, endpoint.token) |
There was a problem hiding this comment.
the Info endpoint in the ServiceX backend doesn't require authentication, so this is not a great test. We could add some authenticated call to the server, or for now just throw away the results from a benign endpoint that does check auth, like /servicex/datasets
servicex/app/check.py
Outdated
| import typer | ||
| from rich import get_console | ||
|
|
||
| from servicex.app.init import verify_token |
There was a problem hiding this comment.
Don't use methods from one cli command in another. If you need a common function for this, move it into the servicex_client
|
hey, how about some unit tests? |
BenGalewsky
left a comment
BenGalewsky
left a comment
There was a problem hiding this comment.
These changes need unit tests
…into 685-add-servicex-check-cli-command
…into 685-add-servicex-check-cli-command
2 participants
Checks all endpoints in
servicex.yamland verifies the connection with token.