Skip to content

Investigating SQL Server 2022 issue #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
LasseEngboChr wants to merge 38 commits into
base: main
Choose a base branch
from
Draft

Investigating SQL Server 2022 issue #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
92b2bd1
test: Getting more info
Mar 28, 2025
8ca9590
test: again
Mar 28, 2025
7988071
test: 3
Mar 28, 2025
4531b9d
test: Only testing the one
Mar 28, 2025
b267f5a
test: again
Mar 28, 2025
356d860
test: again ...
Mar 28, 2025
5876c5a
test: Revering yaml and stepwise test of getTable Signature
Mar 28, 2025
251a825
test: POSIXct as only column
Mar 28, 2025
d06bb23
chore: Update pak.lock
LasseEngboChr Mar 28, 2025
614eb40
test: Avoiding |>
Mar 28, 2025
edaf3f8
Merge branch 'fix/SQL_Server_2022' of https://github.com/ssi-dk/SCDB …
Mar 28, 2025
3ac9a2f
test: Trying if DBI::dbWriteTable also produces the error - it works …
Mar 28, 2025
10257f9
tesst: added prexix
Mar 28, 2025
bf7bb95
test:steps
Mar 28, 2025
e2ed568
test: with as_table_path
Mar 28, 2025
3cc1b13
test: 2B added
Mar 28, 2025
b13a10e
test: adding SQL
Mar 28, 2025
85958cb
test: again and again
Mar 28, 2025
f85ff97
test: -ing
Mar 28, 2025
805775a
test: This is hard
Mar 28, 2025
5ad24c7
test: minimal example lines 286++
Mar 30, 2025
98c9983
chore: Update pak.lock
LasseEngboChr Mar 30, 2025
074330b
test: packageVersion
Mar 30, 2025
5818a38
test: printing package versions
Mar 30, 2025
1a0d4bb
Merge branch 'fix/SQL_Server_2022' of https://github.com/ssi-dk/SCDB …
Mar 30, 2025
7cec2fa
test: Added Sys.info
Mar 30, 2025
b1cd2b6
test:trying the fix from odbc
Mar 31, 2025
1b57d4f
test: Testing fix from ODBC part 2
Mar 31, 2025
4e9b419
fix: Reverting most in the test. Maintaining a install_github from th…
Mar 31, 2025
5e54224
fix: ODBC -> odbc
Mar 31, 2025
de72835
fix: Small adjustments
Mar 31, 2025
c7e3b3a
fix: cat cannot print a list and packageVersion returns a list
Mar 31, 2025
56d863e
test: Why do I get the wrong version now
Mar 31, 2025
ab40510
test: Don't know why it loads the wrong version now. Forcing installa…
Mar 31, 2025
dcb68b5
test: Moving copy_to out of test_that(...)
Mar 31, 2025
bb74021
test: Trying a small mod
Mar 31, 2025
8f8090b
fix: lintr
Mar 31, 2025
a55047a
test: loading odbc library
Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions pak.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,22 +255,22 @@
{
"ref": "broom",
"package": "broom",
"version": "1.0.7",
"version": "1.0.8",
"type": "standard",
"direct": false,
"binary": true,
"dependencies": ["backports", "dplyr", "generics", "glue", "lifecycle", "purrr", "rlang", "stringr", "tibble", "tidyr"],
"dependencies": ["backports", "cli", "dplyr", "generics", "glue", "lifecycle", "purrr", "rlang", "stringr", "tibble", "tidyr"],
"vignettes": false,
"metadata": {
"RemotePkgRef": "broom",
"RemoteType": "standard",
"RemoteRef": "broom",
"RemoteRepos": "https://packagemanager.posit.co/cran/__linux__/noble/latest",
"RemotePkgPlatform": "x86_64-pc-linux-gnu-ubuntu-24.04",
"RemoteSha": "1.0.7"
"RemoteSha": "1.0.8"
},
"sources": "https://packagemanager.posit.co/cran/__linux__/noble/latest/src/contrib/broom_1.0.7.tar.gz",
"target": "src/contrib/x86_64-pc-linux-gnu-ubuntu-24.04/4.4/broom_1.0.7.tar.gz",
"sources": "https://packagemanager.posit.co/cran/__linux__/noble/latest/src/contrib/broom_1.0.8.tar.gz",
"target": "src/contrib/x86_64-pc-linux-gnu-ubuntu-24.04/4.4/broom_1.0.8.tar.gz",
"platform": "x86_64-pc-linux-gnu-ubuntu-24.04",
"rversion": "4.4",
"directpkg": false,
Expand Down Expand Up @@ -2277,7 +2277,7 @@
{
"ref": "jsonlite",
"package": "jsonlite",
"version": "1.9.1",
"version": "2.0.0",
"type": "standard",
"direct": false,
"binary": true,
Expand All @@ -2289,10 +2289,10 @@
"RemoteRef": "jsonlite",
"RemoteRepos": "https://packagemanager.posit.co/cran/__linux__/noble/latest",
"RemotePkgPlatform": "x86_64-pc-linux-gnu-ubuntu-24.04",
"RemoteSha": "1.9.1"
"RemoteSha": "2.0.0"
},
"sources": "https://packagemanager.posit.co/cran/__linux__/noble/latest/src/contrib/jsonlite_1.9.1.tar.gz",
"target": "src/contrib/x86_64-pc-linux-gnu-ubuntu-24.04/4.4/jsonlite_1.9.1.tar.gz",
"sources": "https://packagemanager.posit.co/cran/__linux__/noble/latest/src/contrib/jsonlite_2.0.0.tar.gz",
"target": "src/contrib/x86_64-pc-linux-gnu-ubuntu-24.04/4.4/jsonlite_2.0.0.tar.gz",
"platform": "x86_64-pc-linux-gnu-ubuntu-24.04",
"rversion": "4.4",
"directpkg": false,
Expand Down Expand Up @@ -2774,7 +2774,7 @@
{
"ref": "odbc",
"package": "odbc",
"version": "1.6.0",
"version": "1.6.1",
"type": "standard",
"direct": false,
"binary": true,
Expand All @@ -2786,10 +2786,10 @@
"RemoteRef": "odbc",
"RemoteRepos": "https://packagemanager.posit.co/cran/__linux__/noble/latest",
"RemotePkgPlatform": "x86_64-pc-linux-gnu-ubuntu-24.04",
"RemoteSha": "1.6.0"
"RemoteSha": "1.6.1"
},
"sources": "https://packagemanager.posit.co/cran/__linux__/noble/latest/src/contrib/odbc_1.6.0.tar.gz",
"target": "src/contrib/x86_64-pc-linux-gnu-ubuntu-24.04/4.4/odbc_1.6.0.tar.gz",
"sources": "https://packagemanager.posit.co/cran/__linux__/noble/latest/src/contrib/odbc_1.6.1.tar.gz",
"target": "src/contrib/x86_64-pc-linux-gnu-ubuntu-24.04/4.4/odbc_1.6.1.tar.gz",
"platform": "x86_64-pc-linux-gnu-ubuntu-24.04",
"rversion": "4.4",
"directpkg": false,
Expand Down Expand Up @@ -4256,7 +4256,7 @@
{
"ref": "stringi",
"package": "stringi",
"version": "1.8.4",
"version": "1.8.7",
"type": "standard",
"direct": false,
"binary": true,
Expand All @@ -4268,10 +4268,10 @@
"RemoteRef": "stringi",
"RemoteRepos": "https://packagemanager.posit.co/cran/__linux__/noble/latest",
"RemotePkgPlatform": "x86_64-pc-linux-gnu-ubuntu-24.04",
"RemoteSha": "1.8.4"
"RemoteSha": "1.8.7"
},
"sources": "https://packagemanager.posit.co/cran/__linux__/noble/latest/src/contrib/stringi_1.8.4.tar.gz",
"target": "src/contrib/x86_64-pc-linux-gnu-ubuntu-24.04/4.4/stringi_1.8.4.tar.gz",
"sources": "https://packagemanager.posit.co/cran/__linux__/noble/latest/src/contrib/stringi_1.8.7.tar.gz",
"target": "src/contrib/x86_64-pc-linux-gnu-ubuntu-24.04/4.4/stringi_1.8.7.tar.gz",
"platform": "x86_64-pc-linux-gnu-ubuntu-24.04",
"rversion": "4.4",
"directpkg": false,
Expand Down
19 changes: 18 additions & 1 deletion tests/testthat/test-getTableSignature.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,20 @@
"logical" = TRUE
)

cat(paste0(unlist(packageVersion("odbc")), collapse = "."), "\n") # Delete this block when ODBC is updated

Check warning on line 34 in tests/testthat/test-getTableSignature.R

View workflow job for this annotation

GitHub Actions / ⚙️ Dispatch / lint / 🖋️ Lint 

file=tests/testthat/test-getTableSignature.R,line=34,col=5,[paste_linter] Use paste(), not paste0(), to collapse a character vector when sep= is not used.
cat(search(), "\n")
#if (paste0(unlist(packageVersion("odbc")), collapse = ".") < "1.6.1.9000") {
cat(" Installing ODBC \n")
devtools::install_github(repo = "detule/odbc", ref = "fixup/columns_exact_propagation")
#}
cat("Installed: ", paste0(unlist(packageVersion("odbc")), collapse = "."), "\n")

Check warning on line 40 in tests/testthat/test-getTableSignature.R

View workflow job for this annotation

GitHub Actions / ⚙️ Dispatch / lint / 🖋️ Lint 

file=tests/testthat/test-getTableSignature.R,line=40,col=20,[paste_linter] Use paste(), not paste0(), to collapse a character vector when sep= is not used.

for (conn in c(list(NULL), get_test_conns())) {

if (inherits(conn, "Microsoft SQL Server")) {
options("odbc.batch_rows" = 1000)
}

if (is.null(conn)) {
test_that("getTableSignature() generates signature for update_snapshot() (conn == NULL)", {
expect_identical(
Expand Down Expand Up @@ -283,9 +295,14 @@
}

if (inherits(conn, "Microsoft SQL Server")) {
library(odbc)

Check warning on line 298 in tests/testthat/test-getTableSignature.R

View workflow job for this annotation

GitHub Actions / ⚙️ Dispatch / lint / 🖋️ Lint 

file=tests/testthat/test-getTableSignature.R,line=298,col=5,[unused_import_linter] Package 'odbc' is attached but never used.
cat("ODBC ", paste0(unlist(packageVersion("odbc")), collapse = "."), "\n")

Check warning on line 299 in tests/testthat/test-getTableSignature.R

View workflow job for this annotation

GitHub Actions / ⚙️ Dispatch / lint / 🖋️ Lint 

file=tests/testthat/test-getTableSignature.R,line=299,col=18,[paste_linter] Use paste(), not paste0(), to collapse a character vector when sep= is not used.
data_random2 <- data_random
dr_copy <- dplyr::copy_to(conn, data_random2)

test_that("getTableSignature() generates signature for random data on remote (Microsoft SQL Server)", {
expect_identical(
getTableSignature(dplyr::copy_to(conn, data_random), conn),
getTableSignature(dr_copy, conn),
c(
"Date" = "DATE",
"POSIXct" = "DATETIME",
Expand Down
Loading