Skip to content

Add RJDBC to Suggests#186

Closed
RasmusSkytte wants to merge 5 commits intomainfrom
feature/RJDBC-support
Closed

Add RJDBC to Suggests#186
RasmusSkytte wants to merge 5 commits intomainfrom
feature/RJDBC-support

Conversation

@RasmusSkytte
Copy link
Copy Markdown
Contributor

@RasmusSkytte RasmusSkytte commented Feb 26, 2025

Intent

This PR adds RJDBC to suggests to support connection to Oracle Databases

Fixes #181

Approach

N/A

Known issues

N/A

Checklist

  • The PR passes all local unit tests
  • I have documented any new features introduced
  • If the PR adds a new feature, please add an entry in NEWS.md
  • A reviewer is assigned to this PR

@RasmusSkytte RasmusSkytte self-assigned this Feb 26, 2025
@RasmusSkytte RasmusSkytte force-pushed the feature/RJDBC-support branch 3 times, most recently from 06d5d34 to ec7269b Compare February 27, 2025 10:33
@RasmusSkytte RasmusSkytte marked this pull request as ready for review February 27, 2025 10:35
@RasmusSkytte RasmusSkytte added the enhancement New feature or request label Feb 27, 2025
Copy link
Copy Markdown
Contributor

@LasseEngboChr LasseEngboChr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a test using RJDBC instead of odbc

@RasmusSkytte
Copy link
Copy Markdown
Contributor Author

RasmusSkytte commented Oct 9, 2025

The CI tests now seem to correctly install and connect to the Oracle database.

I therefore recommend that we merge this PR (completing #181) and start implementing the specific functions we need in SCDB to support Oracle in a different PR (which would then fix #182)

@RasmusSkytte
Copy link
Copy Markdown
Contributor Author

Hmm. I have been trying to implement Oracle support over in #195 but this has been much harder than expected.

There seems to be some work going on at odbc which may help us eventually, but for now, I want to close these PRs

@RasmusSkytte RasmusSkytte deleted the feature/RJDBC-support branch December 19, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FEATURE: Add Oracle Database to the CI tests

2 participants