added geojson-rewind and enforce correct geometry #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dokempf
requested changes
Dec 14, 2022
Member
dokempf
left a comment
dokempf
left a comment
There was a problem hiding this comment.
I had done some quick tests with geojson-rewind last week and it threw me some warnings that it only works correctly when the GeoJSON uses the standard conforming CRS (WSG84?). Any thoughts about this?
|
|
||
| for i, segmentation in enumerate(segmentations): | ||
| for j, feature in enumerate(segmentation["features"]): | ||
| # print(segmentations[i]) |
| } | ||
|
|
||
|
|
||
| def enforce_geojson_topology(segmentations): |
Member
There was a problem hiding this comment.
A docstring quickly explaining the problem would be nice here
Collaborator
Author
|
I have not yet gotten any warning, but you are right. |
Collaborator
Author
|
It also seems to mess with the swap functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #387