Skip to content

Fix PHP 8.3 TypeError on non-existent pages #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
frandallfarmer wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix PHP 8.3 TypeError on non-existent pages #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions action/rendertoc.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,11 @@ function handlePostProcess(Doku_Event $event, $param) {
return;
}

// Skip processing for non-existent pages to prevent PHP 8.3 TypeError
if (!page_exists($INFO['id'])) {
return;
}

// TOC Position check
$tocPosition = @$meta['position'] ?: $this->getConf('tocPosition');
if ($ACT == 'preview') {
Expand Down Expand Up @@ -175,6 +180,11 @@ function handleTocRender(Doku_Event $event, $param) {
return;
}

// Skip processing for non-existent pages to prevent PHP 8.3 TypeError
if (!page_exists($INFO['id'])) {
return;
}

// retrieve toc config parameters from metadata
$topLv = @$meta['toptoclevel'] ?: $this->getConf('toptoclevel');
$maxLv = @$meta['maxtoclevel'] ?: $this->getConf('maxtoclevel');
Expand Down Expand Up @@ -204,6 +214,11 @@ function handleContentDisplay(Doku_Event $event, $param) {
return;
}

// Skip processing for non-existent pages to prevent PHP 8.3 TypeError
if (!page_exists($INFO['id'])) {
return;
}

// TOC Position check
$tocPosition = @$meta['position'] ?: $this->getConf('tocPosition');
if (!in_array($tocPosition, [0,1,2,6])) {
Expand Down