Skip to content

Update _popup.js to show the last element. #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
coderwassananmol wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update _popup.js to show the last element. #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9db9750
Update _popup.js to show the last element.
coderwassananmol Oct 10, 2017
49d5c4e
Update file using gulp
coderwassananmol Oct 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions dist/js/sth-select.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,31 +200,33 @@
/**
* Renders all elements in the list of options.
*/
function _renderList(caseSensitive) {
function _renderList() {
_clear();

var rerenderOnEachItem = false;
var $listItems = $([]);
var textFilter = _formatText(caseSensitive, _$filter.val());
var textFilter = _$filter.val().toLowerCase();

_items.forEach(function (item) {
var text = _formatText(caseSensitive, item.text);
if (text.indexOf(textFilter) != -1) {
_items.map(function (item) {
if (item.text.toLowerCase().indexOf(textFilter) != -1) {
var $listItem = _addItem(item, rerenderOnEachItem);
$listItem.click(function () {
_onSelectCallback(item);
hide();
});

$listItems = $listItems.add($listItem);
}
});

_$content.append($listItems);
_$content.one('click', function (event) {
var item = $(event.target).data('item');
_properties.onSelect(item, event);
_onSelectCallback(item);
hide(event);
});

var popupHeight = _calculatePopupHeight();
var titleHeight = _$title.outerHeight();
_$content.outerHeight(popupHeight - titleHeight);
var filterHeight = _$filter.outerHeight();
var contentHeight = popupHeight - titleHeight;
if (_properties.hasFilter) contentHeight = contentHeight - filterHeight;
_$content.outerHeight(contentHeight);
}

/**
Expand Down Expand Up @@ -414,4 +416,4 @@ $(document).ready(function loadFromHtmlAPI() {
function boolFromString(string) {
return string == "true";
}
});
});
6 changes: 5 additions & 1 deletion src/js/_popup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,11 @@
});
let popupHeight = _calculatePopupHeight();
let titleHeight = _$title.outerHeight();
_$content.outerHeight( (popupHeight - titleHeight) );
let filterHeight = _$filter.outerHeight();
let contentHeight = (popupHeight - titleHeight);
if(_properties.hasFilter)
contentHeight = contentHeight - filterHeight;
_$content.outerHeight(contentHeight);
}

/**
Expand Down